Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

LAPACK: add prebuilt dll for MSVC#1018

Merged
ruslo merged 1 commit intoruslo:masterfrom
NeroBurner:lapack-prebuilt
Sep 12, 2017
Merged

LAPACK: add prebuilt dll for MSVC#1018
ruslo merged 1 commit intoruslo:masterfrom
NeroBurner:lapack-prebuilt

Conversation

@NeroBurner
Copy link
Contributor

add lapack 3.7.1 prebuilt for MSVC amd64

This adds a prebuilt dll hosted at https://github.com/NeroBurner/lapack-prebuilt

on MSVC I wasn't able to add a Fortran compiler. But for Unicode support I need to build with MSVC (I wasn't able to make boost::filesystem and MINGW behave).
My solution is to download the prebuilt c-library and provide a cmake-config file when LAPACK is requested when using MSVC

currently I only provide amd64 architecture

Copy link
Owner

@ruslo ruslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on MSVC I wasn't able to add a Fortran compiler. But for Unicode support I need to build with MSVC (I wasn't able to make boost::filesystem and MINGW behave).

Not sure what it means. You have to use Fortran from MinGW to build Lapack with MSVC toolchain?

VERSION
"3.7.1"
URL
https://github.com/NeroBurner/lapack-prebuilt/archive/v3.7.1-msvc-amd64.zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# determine architecture
include(hunter_check_toolchain_definition)
hunter_check_toolchain_definition(NAME "_WIN64" DEFINED WIN64_defined)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use _WIN64_defined or _hunter_win64_defined here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hunter_report_broken_package if _WIN64 is not defined, example:

- add lapack 3.7.1 prebuilt for MSVC amd64
- report brocken package if not on MSVC and amd64
- download zip uploaded directly to release 3.7.1-p0
@NeroBurner
Copy link
Contributor Author

updated

on MSVC I wasn't able to add a Fortran compiler. But for Unicode support I need to build with MSVC (I wasn't able to make boost::filesystem and MINGW behave).

Not sure what it means. You have to use Fortran from MinGW to build LAPACK with MSVC toolchain?

When compiling a project with MSVC which requests the package LAPACK, instead of downloading the source and trying to compiling the Fortran code I let hunter download the prebuilt C-dll.

The dll and lib files are from http://icl.cs.utk.edu/lapack-for-windows/lapack/index.html#libraries.
The cmake-config files are from the install step when compiling with mingw-w64, and I updated them manually to link to the prebuilt dll and lib files.

@ruslo
Copy link
Owner

ruslo commented Sep 7, 2017

instead of downloading the source and trying to compiling the Fortran code

That's kind of what I was really asking. Why we can't compile this from sources?

@NeroBurner
Copy link
Contributor Author

compiling from source would be a mixed toolchain. For LAPACK we need mingw-w64-gfortran, for the rest of the project MSVC is used. I don't know how to do that

@ruslo
Copy link
Owner

ruslo commented Sep 7, 2017

compiling from source would be a mixed toolchain. For LAPACK we need mingw-w64-gfortran, for the rest of the project MSVC is used

Okay, that's what I was thinking about. One more use case for this feature request: https://github.com/ruslo/hunter/issues/495

@NeroBurner
Copy link
Contributor Author

NeroBurner commented Sep 7, 2017 via email

@ruslo
Copy link
Owner

ruslo commented Sep 7, 2017

Shall I add a pr to add MSVC tests?

After tests passed I will merge it to master and update pkg.lapack. Then you can send pull request with enabling MSVC toolchains.

@ruslo
Copy link
Owner

ruslo commented Sep 7, 2017

@ruslo ruslo merged commit 7799c57 into ruslo:master Sep 12, 2017
@ruslo
Copy link
Owner

ruslo commented Sep 12, 2017

@NeroBurner
Copy link
Contributor Author

could you push your local pkg.lapack branch. I see the "Merge branch 'pk.template' into pkg.lapack" commit message, but only in the branch upload.lapack. The branch pkg.lapack is a few commit behind

@ruslo
Copy link
Owner

ruslo commented Sep 13, 2017

could you push your local pkg.lapack branch

Done

@NeroBurner NeroBurner deleted the lapack-prebuilt branch May 16, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments