ts: use TS_VERIFY_CTX_set0_{store,certs}() on OpenSSL 3.4#842
Merged
rhenium merged 1 commit intoruby:masterfrom Jan 22, 2025
Merged
ts: use TS_VERIFY_CTX_set0_{store,certs}() on OpenSSL 3.4#842rhenium merged 1 commit intoruby:masterfrom
rhenium merged 1 commit intoruby:masterfrom
Conversation
In OpenSSL 3.4, TS_VERIFY_CTX_set_certs() and TS_VERIFY_CTX_set_store() are deprecated in favor of the new functions with "set0" in the names. The new functions have a slightly different behavior. They will free the previous value automatically. Increment the reference counter of X509_STORE before setting it to TS_VERIFY_CTX, and do not try to manually unset it. We avoided doing this to work around a bug that was present in older versions of OpenSSL, which has now been fixed in OpenSSL 1.0.2 by commit openssl/openssl@bff9ce4db38b.
db83b4e to
ce37f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS_VERIFY_CTX_set_certs() and TS_VERIFY_CTX_set_store() are deprecated in OpenSSL 3.4 in favor of the new functions with "set0" in the names.
Increment the reference counter of X509_STORE before setting it to TS_VERIFY_CTX. We avoided doing this to work around a bug that was present in OpenSSL < 1.0.2, fixed by openssl/openssl@bff9ce4db38b.
Fixes #837