Rakefile: Manage test files by excluding test files in the test_fips task.#820
Merged
rhenium merged 1 commit intoruby:masterfrom Nov 22, 2024
Conversation
…task. Manage test files by excluding test files rather than adding the target test files in the test_fips task. My motivations for this change are 1. We can test FIPS cases for the test files to be added in the future. 2. We can clarify the remaining failing test files that we need to fix.
Member
Author
|
As a test for this PR, below is the CI test result in OpenSSL master fips on the latest master branch. And below is the CI test result in OpenSSL master fips on this PR. And both results are the same, and it is expected. |
rhenium
approved these changes
Nov 22, 2024
Member
rhenium
left a comment
There was a problem hiding this comment.
That sounds like a good way forward, and as far as I understand the plan is to eventually make rake test compatible with it. Thanks!
Member
Author
Yes. Your understanding is right. Eventually we will make the Thanks for your reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, we have added 18 test files as target files executed in the
test_fipstask to theRakefile. As there are total 33 test files, more than 50% (= 18/33) of the test files have been added.Now I want to manage the test files in the
test_fipstask by excluding test files rather than adding the target test files in the test_fips task. About the excluded test files, I mentioned at #603 (comment).My motivations for this change are