raise when EC_POINT_cmp or EC_GROUP_cmp error instead of returning true#564
Merged
rhenium merged 1 commit intoruby:maint-2.2from Dec 18, 2022
Merged
raise when EC_POINT_cmp or EC_GROUP_cmp error instead of returning true#564rhenium merged 1 commit intoruby:maint-2.2from
rhenium merged 1 commit intoruby:maint-2.2from
Conversation
Member
|
Good catch! |
rhenium
requested changes
Nov 23, 2022
Member
|
The code was originally introduced in 2007. This fix should go to 2.2.x, the oldest branch we currently support. Please rebase this on top of maint-2.2 ( |
3ed6fb8 to
e1e8f3c
Compare
rhenium
approved these changes
Dec 18, 2022
Member
|
(CI failure is irrelevant, being fixed by #572.) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning true when EC_POINT_cmp or EC_GROUP_cmp error, raise instead.