Helper to retrieve CRL URIs from a certificate#275
Merged
ioquatix merged 2 commits intoruby:masterfrom Oct 31, 2019
Merged
Conversation
Member
|
Do you think we should add an example showing how to use it/why to use it? |
Contributor
Author
|
I guess https://github.com/ruby/openssl/blob/master/sample/crlstore.rb could be updated, but that one in itself isn't terribly clear either 😕 I was planning to use it myself in cedarcode/webauthn-ruby#208 where I currently have a more brittle and uglier regex match to get the URI. |
Member
|
For the name of the module, what are your thoughts on the casing, should it be |
Contributor
Author
|
Sounds good to me, updated. |
Contributor
Author
|
Hum, one flaky test that failed (and I can't restart) but the rest is all green. Edit: fixed with a rebase on top of #278 |
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #260
According to RFC 5280 a distribution point can contain a lot of things, but in practice I'm seeing only
fullNameURIs (6).