pass ignore files cli options to language server #495
Merged
+33
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
approved these changes
Jul 10, 2025
|
This looks right, assuming the tests pass I will merge it. |
f50d502 to
3844084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore files options are not currently passed to the language server. It's been bugging me for a while as it means there is no way to stop the vscode plugin from formatting certain files. I presume this is because it makes more sense for the list of files to be compiled outside of the language server.
Please consider this PR as a starting point to discussion/solving this issue, thoughts welcome:
ruby-syntax-tree/vscode-syntax-tree#192