Add the 3.5.0.beta1 release post. #92
Conversation
|
@rspec/rspec can someone review and deploy this asap? |
|
@JonRowe can I also get a release bit on this app? |
|
I'm making breakfast but plan to review this after that. On Sat, Feb 6, 2016 at 6:53 AM, Sam Phippen [email protected]
|
| tests in Rails 5. RSpec has been affected by being downstream of this, but | ||
| fortunately, we were able to make the process relatively smooth for our users. | ||
|
|
||
| If you have existing specs with `:type => :view` or `:type => :controller` |
There was a problem hiding this comment.
It's slightly confusing that Rails' deprecation of controller tests affect view specs. Not sure if it's worth spending any effort explaining why but I found this surprising.
There was a problem hiding this comment.
it's because controller specs and view specs use some of the same code paths. Nobody who tests without RSpec uses view tests, so rails isn't really talking about them. The announced deprecations of controller specs also cover view specs.
|
It's a good blog post, @samphippen. Thanks for leading the 3.5 release! |
20d8b4c to
090ea06
Compare
|
@myronmarston is this good to merge? |
|
LGTM |
Add the 3.5.0.beta1 release post.
|
@rspec/rspec how do we roll this out? |
|
The Readme explains how to deploy. |
|
Your gemfile snippet isn't rendering right, @samphippen:
Can you fix it? You need to use a slightly different syntax for code blocks than github flavored markdown. |
|
Fixed in 39d3ef9. |
No description provided.