Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the RSpec website. #9

Merged
merged 22 commits into from
Jun 4, 2014
Merged

Updating the RSpec website. #9

merged 22 commits into from
Jun 4, 2014

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented May 17, 2014

So opening a PR to discuss and work on the new RSpec website. I'd like to use the refresh branch here as development "master" and this should mean as we branch off it and merge back that we see all our lovely changes add up here. @mootpointer has been working on it but I know @cupakromer has expressed an interest in contributing here (mostly with awesome tutorial content see cupakromer/rspec-tutorial as has @sjahandideh. (I say this on the internets so it must be true).

See #8 for the Redpen draft's, I'm assuming there are further updated ones somewhere @mootpointer?

So I've taken the liberty of sprucing this up a bit as prep for getting it up here, you can see I've set middleman up to squash assets and use directory indexes for pretty urls all things that's be good on the real site. I've also linked up navigation and roughed some outlines for the sort of content we might want.

You can also find a live preview here: http://rspec-www-preview.herokuapp.com/ (Sorry @sjahandideh, feel free to setup a preview on @ninefold instead, I just can't do that easily)

@myronmarston
Copy link
Member

I'd like us to host our own docs rather than relying on rubydoc.info for that. YARD has stuff built in to either run a live server or to generate static HTML that we could include in the site. I'd like for it to be versioned so that people can access the docs for 3.0, 3.1, 3.2, etc.

@sjahandideh
Copy link

Where can i find the designs and content for the home page, about page, etc?

@mootpointer
Copy link
Contributor

I'll share the Dropbox folder Katie gave us. 

A.

On Sun, May 18, 2014 at 8:17 AM, Shamim [email protected] wrote:

Where can i find the designs and content for the home page, about page, etc?

Reply to this email directly or view it on GitHub:
#9 (comment)

@sjahandideh
Copy link

so i put rspec demo on http://rspecwebsitedemo.ninefold-apps.com/ . @JonRowe can you please kindly take that out of heroku website? I'm also waiting for @mootpointer to share the designs with me so that we can have an estimate of how much more work it needs and how many resources we should allocate to this. As i mentioned before, i love rspec and i want it to have a good home :)

@JonRowe
Copy link
Member Author

JonRowe commented May 19, 2014

Sounds good, I've put down the heroku app, how's the ninefold one deployed? It'd be good for either myself, @myronmarston or @cupakromer to able to deploy it.

@JonRowe
Copy link
Member Author

JonRowe commented May 19, 2014

@myronmarston I'll take point on adding in generated Rdoc to this branch I like the idea of having it available ourselves :)

@mootpointer
Copy link
Contributor

@sjahandideh
Copy link

@JonRowe you can either deploy it as a git url ( which is the way i deployed it ) or as a github repo. just make sure you select the refresh branch.

@sjahandideh
Copy link

@mootpointer thanks you. im checking them out right now

@cupakromer
Copy link
Member

@sjahandideh thanks for helping out with this! I'm excited to get this up and running 😸

To deploy are you saying that by simply pushing to the refresh branch on this repo the changes are pushed out to: http://rspecwebsitedemo.ninefold-apps.com/ ?

@sjahandideh
Copy link

@cupakromer well that depends if you select the auto-deploy on the ninefold portal for this app. i haven't done that but im going to do it so that every change to the refresh branch triggers a redeploy.

@sjahandideh
Copy link

@cupakromer wait sorry i can't do that because i dont have owner permissions to this repo.

@JonRowe
Copy link
Member Author

JonRowe commented May 20, 2014

Does it need a hook setting up?

@sjahandideh
Copy link

ah, yea we dont have that automatic redeploy option available with git urls. ill try and deploy it as a github reop so that we can setup the automatic redeployment.

@sjahandideh
Copy link

@JonRowe Ninefold is a platform to deploy your rails app and it doesn't really support middleman without the tricks that @mootpointer used before. its not a big deal, we can work it out.


footer
= image_tag 'brutus-half.png', :alt => "Brutus"
span Crafted by #{ link_to("Ninefold", "https://ninefold.com", target: '_blank') }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, maybe this could say Site crafted by… so that it is not implied that RSpec as a whole is crafted by Ninefold.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair to me. I put that there originally, since it was the tag I was using on all the Ninefold stuff I was building, but in the other cases, they were all Ninefold stuff.

Edit: It should be noted I am no longer employed by Ninefold, so my opinions do not represent Ninefold's.

@JonRowe
Copy link
Member Author

JonRowe commented May 23, 2014

@sjahandideh can you please make your changes as pull requests against this branch, so we can review, otherwise we don't get pinged on changes.

@JonRowe
Copy link
Member Author

JonRowe commented May 23, 2014

(goes for you too @soulcutter but I'll let you off for that one ;)

@sjahandideh
Copy link

@JonRowe sure

@sjahandideh
Copy link

@JonRowe and btw, i've started working on about page. ill create a branch and later a pull request for the changes :)

JonRowe added a commit that referenced this pull request Jun 4, 2014
Updating the RSpec website.
@JonRowe JonRowe merged commit 9dfbcee into master Jun 4, 2014
@JonRowe JonRowe deleted the refresh branch June 4, 2014 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants