Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes for blog pages. #36

Merged
merged 3 commits into from
Dec 26, 2014
Merged

Style changes for blog pages. #36

merged 3 commits into from
Dec 26, 2014

Conversation

cohitre
Copy link
Contributor

@cohitre cohitre commented Dec 19, 2014

  • Adding extra margin around blog posts headers

@myronmarston
Copy link
Member

Thanks @cohitre. This is definitely better. There are a couple parts that I think still look poor, though:

IMO, code examples don't look good:

screen shot 2014-12-19 at 9 42 02 am

Compare that to how it looks on my blog:

screen shot 2014-12-19 at 9 43 24 am

The main problem is the spacing. I tried adding this CSS to blog.css.scss:

.blog_post {
  pre {
    line-height: 1.25em;
    font-size: 90%;
    font-family: Menlo, Monaco, "Andale Mono", "lucida console", "Courier New", monospace !important;
  }
}

...which looks quite a bit better, I think:

screen shot 2014-12-19 at 9 49 28 am

Is that how you'd do that? One of the code snippets also wraps, and I can't figure out how to add scroll bars (I tried overflow: scroll...):

screen shot 2014-12-19 at 9 50 37 am

vs (from my blog):

screen shot 2014-12-19 at 9 51 10 am

The other part that looks subpar is the bullet points later in the blog post:

screen shot 2014-12-19 at 9 52 56 am

Compared to:

screen shot 2014-12-19 at 9 53 37 am

...which looks much better, IMO.

Do you have time to take a stab at improving that?

@myronmarston
Copy link
Member

BTW, the arrows for bullet points are kinda a cool stylistic thing on my blog but I don't expect that here...I'm thinking more about the spacing and indentation.

@cohitre
Copy link
Contributor Author

cohitre commented Dec 26, 2014

The last two commits add some styling for the pre and ul tags. I moved the bullets so they are aligned with the rest of the text and I also reduced some of the margin when they are next to h3 tags.

For the pre tags I added some better styles to fix font selection, size and scroll bars behavior.

@cohitre
Copy link
Contributor Author

cohitre commented Dec 26, 2014

list:

screen shot 2014-12-26 at 1 28 58 pm

pre:

screen shot 2014-12-26 at 2 13 23 pm

@myronmarston
Copy link
Member

❤️ ❤️ ❤️ This is a huge improvement. I really appreciate you taking the time to improve our CSS, @cohitre!

myronmarston added a commit that referenced this pull request Dec 26, 2014
Style changes for blog pages.
@myronmarston myronmarston merged commit 77ffcf5 into rspec:blog-spike Dec 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants