Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon #23

Merged
merged 2 commits into from
Nov 4, 2014
Merged

Add favicon #23

merged 2 commits into from
Nov 4, 2014

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Nov 4, 2014

@myronmarston
Copy link
Member

Looks reasonable.

I noticed you updated the ruby version in the Gemfile. Is it really that important to lock it down in the Gemfile? I had to install 2.1.2 just to work with this repo and now I'll have to install 2.1.4 for that purpose. Given that ruby isn't involved with the deployed site, do we care what version devs use locally as long as it's 2.1.x and we get the same output?

JonRowe added a commit that referenced this pull request Nov 4, 2014
@JonRowe
Merge pull request #23 from rspec/add_favicon
fe28683 
Add favicon
@JonRowe JonRowe merged commit fe28683 into source Nov 4, 2014
@JonRowe JonRowe deleted the add_favicon branch November 4, 2014 21:43
@JonRowe
Copy link
Member Author

JonRowe commented Nov 4, 2014

Guess not, just needs to be 2.1

@myronmarston
Copy link
Member

Does the ruby directive in gemfiles support ruby '2.1' (with no specification for the 3rd part)?

@JonRowe
Copy link
Member Author

JonRowe commented Nov 4, 2014

See #24, also FYI
screen shot 2014-11-05 at 8 50 48

@myronmarston
Copy link
Member

👍 That looks great :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonRowe @myronmarston