Misc changes from Myron #19
Conversation
- Favor `RSpec.describe` for outer describe. - Remove unneeded blank lines (it made the page longer than it needed to be). - "for an all gutter game" reads better.
| over by David Chelimsky who brought it into the limelight as a behaviour | ||
| driven style development tool. David also built rspec-rails, which provided | ||
| tight integration with | ||
| = link_to 'Ruby on Rails', 'http://rubyonrails.org/' |
There was a problem hiding this comment.
I believe you can use #{} interpolation to tidy this up.
There was a problem hiding this comment.
Ah, I was wondering about that...I'll give that a shot.
|
BTW, @JonRowe, I noticed that there's no favicon -- can you make one from the logo? |
Also, added a release date for RSpec 3.
The old spec was more specific (an all zero game) then the implementation (which summed all the pins). Given we didn’t want to do the “simplest” thing and hard code a return value of 0, it’s better to have a spec that actually forces the summing of the pins.
|
OK, @JonRowe, I used string interpolation. Thanks for the tip. I also updated the example spec -- let me know what you think. On a side note...I think the "created with the assistance of Ninefold" footer looks pretty janky. What's with the cattle icon? Can we clean that up? |
|
That's Brutus, their "mascot", I'm open to improving it, I asked them if they wanted to improve it but they were fine with it, we can always tweak it though :) |
Hmm, I had no idea it's their mascot. I expected to see something like the "stacks" logo I see at their site. Regardless, it'd be good to center the footer text and logo rather than it being left-aligned. Also, the footer seems much taller than it needs to be. Should we shrink it a bit? My CSS skills are virtually non-existent so it's probably best if someone else makes those changes. |
|
BTW, do you have any feedback on what I wrote up as the history? |
|
Regarding the favicon, it appears there's a middleman plugin that may help here: https://github.com/follmann/middleman-favicon-maker |
|
|
||
| p | ||
| | RSpec 1.0 was released in May of 2007, and included many of the | ||
| features that are still present in RSpec today. |
There was a problem hiding this comment.
Given that HTML won't respect this spacing there's no need for the new line break here.
There was a problem hiding this comment.
I didn't intend for this to be a line break in the HTML..these were originally separate paragraphs and then I joined them into one. I'll reformat it a bit so it doesn't look odd in the source, though.
|
Changes look good to me, is it worth mentioning the expansion of the core team before RSpec 3? I'll work on a favicon :) |
I thought about it, but if we mention the history of some folks joining the core team I'd feel obligated to mention when everyone who has ever been on the core team joined. I don't think our users care to know that level of detail. |
|
|
||
| p | ||
| | RSpec began life in 2005 as an experiment by Steven Baker. It was taken | ||
| over by David Chelimsky who brought it into the limelight as a behaviour |
There was a problem hiding this comment.
Not necessary, but you could say "taken over by David Chelimsky in 2006".
There was a problem hiding this comment.
Good idea. I added the year in 4502ef9 although I worded it differently -- I didn't think it read well to say "taken over by David Chelimsky in 2006 who brought it into the limelight...".
|
LGTM. |
The history could use some feedback, particularly from @dchelimsky. Is it accurate? Did I cover the important things?
/cc @JonRowe