Skip to content

Ditch middleman-deploy in favour of git push without submodules. #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 3, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Aug 1, 2020

Thanks to the @github teams latest changes to Github pages, we can now deploy from either / or docs on any branch, so this PR builds on @pirj's #155 with the intention of using the primary source branch with the docs folder as build output.

@JonRowe JonRowe requested a review from pirj August 1, 2020 08:59
@JonRowe
Copy link
Member Author

JonRowe commented Aug 1, 2020

This is currently on rspec-staging

@pirj
Copy link
Member

pirj commented Aug 1, 2020

+965,744 :cereal-guy:

@JonRowe
Copy link
Member Author

JonRowe commented Aug 1, 2020

+965,744 :cereal-guy:

I know right, but this is the only PR this large hopefully.

@JonRowe
Copy link
Member Author

JonRowe commented Aug 3, 2020

I removed the push language for production and protected source, good to merge?

@pirj
Copy link
Member

pirj commented Aug 3, 2020

Look great, thanks!

@JonRowe JonRowe merged commit 4409fa2 into source Aug 3, 2020
@JonRowe JonRowe deleted the folder-deploy branch August 3, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants