Remove yard plugin and generate last minor version documentation #138
Conversation
There was a problem hiding this comment.
So mostly this looks like changes dropping the charset stuff and the google analytics scripts but its also been generated from the wrong version, so theres unintentional changes here too, I've flagged things I think are wrong version, some just seem to be spacing changes did you run your script on this? Apologies for the terse comments in places, but I wanted to flag every bad file...
source/documentation/3.9/rspec-mocks/RSpec/Mocks/MessageExpectation.html
Outdated
Show resolved
Hide resolved
source/documentation/3.9/rspec-core/RSpec/Core/ExampleGroup.html
Outdated
Show resolved
Hide resolved
source/documentation/3.9/rspec-core/RSpec/Core/Configuration.html
Outdated
Show resolved
Hide resolved
| <span class='object_link'><a href="RSpec/Matchers.html#include-instance_method" title="RSpec::Matchers#include (method)">#include</a></span> | ||
| <small>RSpec::Matchers</small> | ||
| <span class='object_link'><a href="RSpec/Matchers/BuiltIn/RespondTo.html#ignoring_method_signature_failure!-instance_method" title="RSpec::Matchers::BuiltIn::RespondTo#ignoring_method_signature_failure! (method)">#ignoring_method_signature_failure!</a></span> | ||
| <small>RSpec::Matchers::BuiltIn::RespondTo</small> |
There was a problem hiding this comment.
These changes don't look like spacing changes... :S
There was a problem hiding this comment.
There is some reordering. I don't no why but it doesn't seem to have impact in method list.
Use rspec/rspec-dev#247 To avoid a big diff, empty line removal is commented ```diff --- a/Rakefile +++ b/Rakefile @@ -81,7 +81,7 @@ task :update_docs, [:version, :branch, :website_path] do |t, args| Bundler.unbundled_system %Q{ag -l src=\\"\\\(?:..\/\\\)*js #{doc_destination_path} | xargs -I{} sed #{in_place} 's/src="\\\(..\\\/\\\)*js/src="\\\/documentation\\\/#{args[:version]}\\\/#{project}\\\/js/' {}} Bundler.unbundled_system %Q{ag -l href=\\"\\\(?:..\/\\\)*css #{doc_destination_path} | xargs -I{} sed #{in_place} 's/href="\\\(..\\\/\\\)*css/href="\\\/documentation\\\/#{args[:version]}\\\/#{project}\\\/css/' {}} - Bundler.unbundled_system %Q{ag --html -l . #{doc_destination_path} | xargs -I{} sed #{in_place} /^[[:space:]]*$/d {}} + # Bundler.unbundled_system %Q{ag --html -l . #{doc_destination_path} | xargs -I{} sed #{in_place} /^[[:space:]]*$/d {}} ```
|
|
||
|
|
||
| <span class="summary_desc"><div class='inline'><p>Used by other matchers to suppress a check.</p> | ||
| </div></span> |
There was a problem hiding this comment.
It is because it is included in 3.9.1.
https://github.com/rspec/rspec-expectations/blob/d671f8854532168b5e57c0479b5e6e5a61bc6cc8/lib/rspec/matchers/built_in/respond_to.rb#L107
The current documentation version is the 3.9.0
http://rspec.info/documentation/3.9/rspec-expectations/file.Changelog.html
| 16 | ||
| 17 | ||
| 18 | ||
| 19</pre> |
There was a problem hiding this comment.
Change included in 3.9.1
| <span class='kw'>end</span></pre> | ||
| </td> | ||
| </tr> | ||
| </table> |
There was a problem hiding this comment.
Change included in 3.9.1
|
|
||
| <h3>3.9.0 / 2019-10-08</h3> | ||
|
|
||
| <p><a href="http://github.com/rspec/rspec-expectations/compare/v3.8.6...v3.9.0">Full Changelog</a></p> |
There was a problem hiding this comment.
It should be better now.
| <span class='object_link'><a href="RSpec/Matchers.html#include-instance_method" title="RSpec::Matchers#include (method)">#include</a></span> | ||
| <small>RSpec::Matchers</small> | ||
| <span class='object_link'><a href="RSpec/Matchers/BuiltIn/RespondTo.html#ignoring_method_signature_failure!-instance_method" title="RSpec::Matchers::BuiltIn::RespondTo#ignoring_method_signature_failure! (method)">#ignoring_method_signature_failure!</a></span> | ||
| <small>RSpec::Matchers::BuiltIn::RespondTo</small> |
There was a problem hiding this comment.
There is some reordering. I don't no why but it doesn't seem to have impact in method list.
003568d to
4a6ff3a
Compare
|
Looks good now! |
|
Thanks! I need to buy you a new trackpad now... 😄 |
This plugin add extra steps when people want to generate documentation. We do not want to use Google Analytics anymore + we prefer to use the default header and footer from Yard that is optimized for mobile.