-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rspec-rails 4.0.0 documentation #136
Conversation
benoittgt
commented
Mar 24, 2020
- Add rake command to generate yard documentation rspec-rails#2298
I think it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to generate from the released verson @benoittgt but otherwise 👍
74f8f84
to
2aaf3f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why theres so much whitespace?
Good question. I opened an issue on rdoc ruby/rdoc#759 |
Do you want to add some white space trimming to the bash command? |
That's not a bad idea. If I can fix it on If kids are sleeping enough tomorrow I will handle it :) |
It takes some times to fix on rdoc/erb. In the meantime I'm gonna add a bash command. :) |
For the white space. #139 |
2aaf3f6
to
a511b93
Compare
I had to skip the git checkout command from the rake task for #136 (comment) Changelog seems ok No blank lines in html. |
I'm happy if you're happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 LGTM
Not deployed yet http://rspec.info/documentation/4.0/rspec-rails/ 😕 |
Yep :) |