Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rspec-rails 4.0.0 documentation #136

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Add rspec-rails 4.0.0 documentation #136

merged 1 commit into from
Apr 9, 2020

Conversation

benoittgt
Copy link
Member

@benoittgt
Copy link
Member Author

I think it can be merged.

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to generate from the released verson @benoittgt but otherwise 👍

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why theres so much whitespace?

@benoittgt
Copy link
Member Author

Good question. I opened an issue on rdoc ruby/rdoc#759

@JonRowe
Copy link
Member

JonRowe commented Mar 31, 2020

Do you want to add some white space trimming to the bash command?

@benoittgt
Copy link
Member Author

benoittgt commented Mar 31, 2020

That's not a bad idea. If I can fix it on rdoc it could be great too but maybe a new rdoc release will not be soon.

If kids are sleeping enough tomorrow I will handle it :)

@benoittgt
Copy link
Member Author

It takes some times to fix on rdoc/erb. In the meantime I'm gonna add a bash command. :)

@benoittgt
Copy link
Member Author

For the white space. #139

@benoittgt benoittgt force-pushed the add-rspec-rails-4 branch from 2aaf3f6 to a511b93 Compare April 8, 2020 21:46
@benoittgt
Copy link
Member Author

benoittgt commented Apr 8, 2020

I had to skip the git checkout command from the rake task for #136 (comment)

Changelog seems ok

Capture d’écran 2020-04-08 à 23 25 00

Capture d’écran 2020-04-09 à 00 06 28

No blank lines in html.

@JonRowe
Copy link
Member

JonRowe commented Apr 9, 2020

I'm happy if you're happy.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@benoittgt benoittgt merged commit 1e5cca9 into source Apr 9, 2020
@benoittgt benoittgt deleted the add-rspec-rails-4 branch April 9, 2020 12:59
@benoittgt benoittgt restored the add-rspec-rails-4 branch April 9, 2020 12:59
@benoittgt benoittgt deleted the add-rspec-rails-4 branch April 9, 2020 12:59
@pirj
Copy link
Member

pirj commented Apr 9, 2020

@benoittgt
Copy link
Member Author

benoittgt commented Apr 9, 2020

Yep :)
I'm gonna try to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants