Add 'ostruct' to example app Gemfile #2796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, specs are failing for the "Ruby: 3.3, Rails: ~> 7.1.0" and "Ruby: 3.3, Rails: ~> 7.2.0" matrix builds. This is caused by Ruby 3.3.5 (released yesterday, 2024-09-03) now warning if `ostruct` is loaded from the standard library, rather than from a gem. This change fixes the failing specs by adding the `ostruct` gem to the `Gemfile` of the example app, which causes the problematic warning not to be emitted by Ruby.
This was referenced Sep 4, 2024
|
I think that #2794 aims to solve the same problem that this PR does (i.e. currently failing specs for some matrix builds on |
|
👋 Thanks but its actually not just ostruct and is actually Rails issue upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, specs are failing for the "Ruby: 3.3, Rails: ~> 7.1.0" and "Ruby: 3.3, Rails: ~> 7.2.0" matrix builds. This is caused by Ruby 3.3.5 (released yesterday, 2024-09-03) now warning if
ostructis loaded from the standard library, rather than from a gem.This change fixes the failing specs by adding the
ostructgem to theGemfileof the example app, which causes the problematic warning not to be emitted by Ruby.