Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we were seeing a throw from rviz with the following message:
Here, the
/nix/store/44kcmy9bsw44y13bf7x5kzlm9s4cdhpr-libgccjit-10.3.0/lib/
directory is a symlink to itself, so there's an endless recursion. Theboost::filesystem::exists
method throws in this instance, but the exception is not caught anywhere, so rviz exits.Instead, it is safer to use the overload that takes the error code and ensure that the function returned success, I don't think pluginlib should ever result in an uncaught throw?
fyi @mikepurvis, @jasonimercer, @nlunscher-cpr (CORE-23076)