[noetic] Move LibraryLoadExceptions down a level #221 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges. (ros#221) Signed-off-by: David V. Lu <[email protected]>
sloretz
reviewed
May 4, 2022
| std::ostringstream error_msg; | ||
| error_msg << "Could not find library corresponding to plugin " << lookup_name << | ||
| ". Make sure the plugin description XML file has the correct name of the library."; | ||
| throw pluginlib::LibraryLoadException(error_msg.str()); |
There was a problem hiding this comment.
Making this method throw where it didn't previously seems like a significant change in a released distro. I could be convinced with a deep enough pre-release test though.
The folks working on ros-o might be interested in this though https://github.com/ros-o/pluginlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#221 for noetic