-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: human readable dimension filters in URL #5340
Conversation
@briangregoryholmes : Can you resolve the conflicts here ? Is this ready to review ? |
@ericpgreen2 According to the Notion, dimension values are required to be surrounded by some form of single quotes. I updated the description with a variety of examples. Unfortunately, I don't think it's practical to validate whether a dimension value is valid, though that's certainly something we can discuss. I've added some guard rails and an updated warning if we're able to detect that something should be quoted that isn't. Added cloud support. |
Oh, got it now, thanks. I commented in the Notion doc, but IMO the ephemeral nature of these filters makes for a frustrating UX. Often, I find myself getting some part of the filter syntax incorrect. I would like to iterate on the filter / edit it after submission. But when the filter is immediately transformed into its protobuf representation, I cannot edit what I input. Let's wait for feedback from @mindspank and @nishantmonu51. |
https://www.notion.so/rilldata/Passing-Filters-as-part-of-URL-ac2972fcd3f64de3af20838ec1c0231b?pvs=4
The API is largely taken from https://learn.microsoft.com/en-us/power-bi/collaborate-share/service-url-filters , but see the notion doc above for greater detail.
Single value, no parenthesis:
"dimension_0 eq 'Zoom'"
dimension_0 eq 'Zoom'
With parentheses:
"dimension_0 eq ('Zoom')"
dimension_0 eq ('Zoom')
"dimension_0 eq ('Zoom', 'Zapier')"
dimension_0 eq ('Zoom', 'Zapier')
Exclude:
dimension_0 ne ('Zoom')
dimension_0 ne 'Zoom'
Multiple filters:
dimension_0 eq ('Zoom', 'Zapier') and dimension_1 eq 'Standard Plan'
Angled versions of single and double quotes (if copied from a text editor that automatically changes the character) should also work:
”dimension_0 eq (‘Zoom’, ‘Zapier’)”