Skip to content

Fix playground bundle API #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

Fix playground bundle API #7486

merged 3 commits into from
May 18, 2025

Conversation

cometkim
Copy link
Member

@cometkim cometkim commented May 18, 2025 •
edited
Loading

But playground should adopt module.

PPX seems to be buggy.

@cometkim
playground: set global for the compatibility reason
5fb190c 
But playground should adopt module.
@cometkim cometkim requested a review from cknitt May 18, 2025 18:03
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 18, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7486

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7486

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7486

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7486

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7486

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7486

commit: e3092fc

@cometkim
Copy link
Member Author

image
Should be api_version, but there is api. Maybe jsoo bug?

@cometkim cometkim changed the title playground: set global for the compatibility reason Fix playground bundle API May 18, 2025
@cometkim cometkim force-pushed the playground-compatibility branch from f73b4b7 to e3092fc Compare May 18, 2025 18:39
@cometkim cometkim merged commit 060edd5 into rescript-lang:master May 18, 2025
17 checks passed
@cometkim cometkim deleted the playground-compatibility branch May 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cometkim @cknitt