Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 6, 2018

Thanks @nette /DI

See nette/di#178

@TomasVotruba TomasVotruba changed the title [experimental] Try argument array autowire, thanks @nette [experimental] Try argument array autowire Oct 6, 2018
@TomasVotruba TomasVotruba force-pushed the autowire-array-param-ctor branch 2 times, most recently from 13cb437 to 0f8767a Compare October 6, 2018 04:42
@TomasVotruba TomasVotruba requested a review from mssimi October 6, 2018 04:42
@TomasVotruba TomasVotruba force-pushed the autowire-array-param-ctor branch 5 times, most recently from 462d2c4 to 79605af Compare October 6, 2018 15:01
@TomasVotruba TomasVotruba changed the title [experimental] Try argument array autowire Add AutowireArrayParameterCompilerPass Oct 6, 2018
@TomasVotruba TomasVotruba force-pushed the autowire-array-param-ctor branch from 79605af to 930ce89 Compare October 6, 2018 15:21
@TomasVotruba TomasVotruba merged commit f52944e into master Oct 6, 2018
@TomasVotruba TomasVotruba deleted the autowire-array-param-ctor branch October 6, 2018 15:21
"sort-packages": true
}
},
"minimum-stability": "dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this adding and removing just to test Symplify.

If we try to use Rector with a repo that does not support dev versions, Rector won't install.

(Btw, remember me about this for us to discuss in Prague)

Copy link
Member Author

@TomasVotruba TomasVotruba Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only temporary. Tagged version should be installed prefferable. I'm tagging quite often recently.

I'll update README.md to reflect that

TomasVotruba added a commit that referenced this pull request Aug 13, 2021
rectorphp/rector-src@7b8f4de [CodeQuality] Skip FixClassCaseSensitivityNameRector on function name exists (#660)
echo511 pushed a commit to echo511/rector that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants