Update Implicit return to check if/switch for single expression#6310
Open
nandhinisubbu wants to merge 4 commits intorealm:mainfrom
Open
Update Implicit return to check if/switch for single expression#6310nandhinisubbu wants to merge 4 commits intorealm:mainfrom
nandhinisubbu wants to merge 4 commits intorealm:mainfrom
Conversation
…ent with single return expression
Generated by 🚫 Danger |
SimplyDanny
requested changes
Oct 25, 2025
Collaborator
There was a problem hiding this comment.
That's cool. Thanks @nandhinisubbu!
Logically, this looks about right. Did you consider if expressions as the only statements in switch cases and vice versa? I think, there should be some kind of recursion to cover that.
With respect to code structure, I'd add all the functions with a single syntax node argument as computed properties to the syntax node itself. That also separates them a little from the rule's implementation, so that the visitor as the entry point is rather small and only provides the entry points.
Other than that, we should probably make checking of if and switch expression optional. I can imagine, not everyone wants to have them checked. Then, for SwiftLint itself, keep the option off and enable to only in a follow-up PR to separate the concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement - #6167