fix: webkit usage #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview 4cba725 failed. Build logs
🤖 By surge-preview |
afc163
reviewed
Jul 19, 2023
| useLayoutEffect(() => { | ||
| if (mergedLock) { | ||
| const scrollbarSize = getScrollBarSize(); | ||
| const scrollbarSize = getTargetScrollBarSize(document.body).width; |
Member
There was a problem hiding this comment.
是不是应该监听元素所在的 dom 容器的滚动条宽度，有可能只是局部覆盖了样式。
Member
Author
There was a problem hiding this comment.
暂时不用，目前这个 hooks 只处理 body，下面的样式锁定也是写死的 body。
Member
Author
There was a problem hiding this comment.
and 动态锁定可以开新的 PR 作 feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve ant-design/ant-design#43485