Replace include guards with "#pragma once" #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the database model generator scripts.
Owner
|
Thanks! I hope you did automate this change :-) |
Contributor
Author
|
I did automate the change, but then had to go manually over all the files just to make sure that the regular expressions in my script updated the files correctly :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our previous discussion here #500
this PR replaces the header include guards with
#pragma oncein all header files and in the python generator scripts. All tests (core+postgresql+mysql+sqlite3) ran successfully.The
#pragma onceis not standard but is supported by all major C++ compilers and easier to maintain than the old-style #ifndef #define...#endif include guards.