Skip to content

Conversation

@eluce2
Copy link
Contributor

@eluce2 eluce2 commented Jan 12, 2026

Description

Adds suggestion from #24399

Checklist

- update lints
- Added new clipboard conversion commands for FileMaker: \'Convert FM to XML\' and \'Convert XML to FM\'. Updated CHANGELOG and package.json to reflect these changes.
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: filemaker-snippets Issues related to the filemaker-snippets extension platform: macOS OP is author The OP of the PR is the author of the extension labels Jan 12, 2026
@raycastbot
Copy link
Collaborator

Thank you for the update! 🎉

Due to our current reduced availability, the initial review may take up to 10-15 business days.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 12, 2026

Greptile Overview

Greptile Summary

This PR adds two new clipboard conversion commands to the FileMaker Snippets extension, providing quick utilities to convert between FileMaker clipboard format and XML text.

Key Changes

New Commands:

  • fm-to-xml: Converts FileMaker clipboard content to XML text and copies it to clipboard
  • xml-to-fm: Reads XML from clipboard, validates it's not empty, and writes it back as FileMaker clipboard content

Code Quality Improvements:

  • Removed unused imports (Detail from dynamic-fields-list.tsx, FMObjectsToXML from create-snippet.tsx)
  • Added CLAUDE.md documentation for AI assistant guidance

Implementation Details:
Both new commands follow proper patterns:

  • Use showToast with animated style during processing
  • Properly handle errors with try-catch blocks
  • Display user-friendly messages with showHUD on success
  • Validate input (xml-to-fm checks for empty clipboard)
  • Hide toast before showing HUD to avoid UI clutter

The commands integrate well with the existing FmClipTools architecture (FMObjectsToXML and XMLToFMObjects functions) and follow the extension's established patterns for no-view commands.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - adds useful utility commands with proper error handling
  • Score of 4 reflects solid implementation with one minor style issue: the new commands have proper error handling, validation, and follow established patterns. The unused React import in manage-locations.tsx is a minor style issue that doesn't affect functionality. All changes are additive (no breaking changes), and the new commands are well-isolated.
  • manage-locations.tsx has an unnecessary import that could be cleaned up, but this is a minor style issue

Important Files Changed

File Analysis

Filename Score Overview
extensions/filemaker-snippets/CHANGELOG.md 5/5 Added entry for new FM clipboard conversion commands with proper formatting
extensions/filemaker-snippets/package.json 5/5 Added two new no-view commands (fm-to-xml, xml-to-fm) with proper configuration
extensions/filemaker-snippets/src/fm-to-xml.tsx 4/5 New command converting FileMaker clipboard to XML text with proper error handling
extensions/filemaker-snippets/src/xml-to-fm.tsx 4/5 New command converting XML to FileMaker clipboard with proper validation and error handling

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -1,4 +1,4 @@
import { useState } from "react";
import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The React import is not used in this file and can be removed. Modern React with JSX transform doesn't require importing React.

Suggested change
import React from "react";
import {

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: filemaker-snippets Issues related to the filemaker-snippets extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants