feat: add suport for Metadata API

[spameier]

Reference: https://docs.acrcloud.com/reference/metadata-api

This adds support for the Metadata API.

[spameier]

Related: radiorabe/suisa_sendemeldung#268

[hairmare]

it should probably also pass kwargs along so users can pass additional args to requests.get (like a session for retry/backoff).

Suggested change

	return self.json(path="/api/external-metadata/tracks", params=params).get(
	"data"
	)
	return self.json(
	path="/api/external-metadata/tracks",
	params=params,
	**kwargs,
	).get("data")

[spameier]

Ok good idea

[hairmare]

imo libs should not have side effects like print()

Suggested change

print(error)

[spameier]

Yes, I just pushed the code to have it somewhere. I agree :)

[hairmare]

Is this error persistent? if it's a temporary error a retry/backoff loop might be better than ignoring it.

[hairmare]

🤔 retry/backoff code is already here:

python-acrclient/acrclient/client.py

Lines 46 to 56 in 399bcc9

	Parameters:
	retries: Total number of retries to allow.
	backoff_factor: A backoff factor to apply between attempts after the
	second try (most errors are resolved immediately by a second try
	without a delay). urllib3 will sleep for::
	{backoff factor} * (2 ** ({number of total retries} - 1))
	seconds. If the backoff_factor is 0.1, then :func:`Retry.sleep`
	will sleep for [0.0s, 0.2s, 0.4s, ...] between retries. It will
	never be longer than `backoff_max`.
	By default, backoff is set to 0.1.

maybe we need to tune it, or it doesn't include 500 errors

[spameier]

For some entries, the error persists and for some it returns 200 after retrying a few seconds later. You're absolutely correct to handle this in the central location.