added option to get decimal point in uncertainty formatted with "parenthesis" notation#60
added option to get decimal point in uncertainty formatted with "parenthesis" notation#60alusiani wants to merge 2 commits intor-quantities:masterfrom
Conversation
…h "parenthesis" notation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 97.28% 96.60% -0.69%
==========================================
Files 12 12
Lines 516 530 +14
==========================================
+ Hits 502 512 +10
- Misses 14 18 +4 ☔ View full report in Codecov by Sentry. |
Enchufa2
left a comment
There was a problem hiding this comment.
Great, thanks for this. I see that some of the changes that I did in the last commits have been undone for some reason. Please restore them. Comments below.
|
Sorry for the changes, I should have checked more carefully. I was merging from an older revision I did. Part of the changes were related to using meld with omission of whitespace diffs. I have now applied all requested changes, committed and pushed to github. As far as I understand, that should be enough, please let me know if I also need to resubmit the pull request. |
|
Thanks! I renamed (and shortened) the new option, and added a new argument |
No problem! I am not an expert of pull requests and have not realized that a push permission was asked or required. |
|
It is not required, but it is convenient when, like in this case, the owner of the repo wants to add some adjustments to the PR. |
Hi,
I propose a small unobstructive addition to the code in order to optionally get the decimal point formatted when using the "parenthesis" notation. Example of usage: