-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualcomm AI Engine Direct - Mimi Enablement Stage 2 #10098
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10098
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 08759d6 with merge base e29a4b5 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
3377f9d
to
a7cd07a
Compare
a7cd07a
to
4501ff2
Compare
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
from executorch.exir.pass_base import ExportPass, PassResult | ||
|
||
|
||
class Remove0DTensor(ExportPass): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the logic in https://github.com/pytorch/executorch/blob/main/backends/transforms/rank_0_to_rank_1.py can be applied here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cccclai,
Thanks for reviewing the PR.
I believe the pass you are suggesting is to change input from 0d to 1d tensor.
However, for our case, this 0D tensor happened during select
op in the middle of graph. We just removed this select
op since it does not affect the logic of the graph.
The exact point where 0D tensor occurs in mimi is under moshi/quantization/core_vq.py
, where is tries to create a 1D tensor and retrieve index 0.
Summary
Commands to Execute the model
10 sec as a batch (1 inference for 10 sec audio):
python examples/qualcomm/oss_scripts/moshi/mimi.py -b build-android -s $DEVICE -m SM8650 --chunks_per_batch 125
80s as a batch (125 inferences for 10 sec audio)
python examples/qualcomm/oss_scripts/moshi/mimi.py -b build-android -s $DEVICE -m SM8650
Test plan