Skip to content

Add a time sequence prediction example #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add a time sequence prediction example #102

wants to merge 3 commits into from

Conversation

fuzihaofzh
Copy link
Contributor

Hi,
I have made a time sequence prediction example, which I think, is capable to illustrate the usage of LSTMCell in pytorch. It's enough simple and fun and is a good small case for beginners who are interested in either pytorch or time sequence.
Please feel free to tell me if it go against of your principles of designing the examples. I'll try to make it more friendly and easy to use for beginners.

Add image of time_sequence_prediction
@soumith
Copy link
Member

soumith commented Mar 21, 2017

OpenNMT has been moved to https://github.com/OpenNMT/OpenNMT-py and will be continuing development there by the OpenNMT team and other community members.

Please send pull requests over there.

Thank you.

@soumith soumith closed this Mar 21, 2017
@fuzihaofzh
Copy link
Contributor Author

Dear @soumith, I'm sorry for modified a small bug in OpenNMT while submit it with a new example. This is a new example to show how to do time sequence prediction with pytorch and it have no relation with OpenNMT. Can I submit this new example again without the modification of OpenNMT?

@soumith
Copy link
Member

soumith commented Mar 22, 2017

actually, sorry i didn't notice. Yes, your example will be helpful. can you open a PR without the OpenNMT modification?
Thanks.

@fuzihaofzh
Copy link
Contributor Author

@soumith I have created another pull request: #118 . Please check it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants