Merged
Conversation
pradyunsg
approved these changes
Apr 17, 2023
Member
+1 to this. |
0e43a2e to
097bb06
Compare
Member
Author
|
rebased on top of #121 |
Member
|
(#99 needs fixes, which I have found by updating python/cpython#99381 -- working on a PR now. Sorry!) Edit: Fix is at #127 |
Member
|
#127 merged 🚀 |
AA-Turner
approved these changes
Apr 25, 2023
d0a8972 to
846add6
Compare
Member
Author
|
Rebased on top of #127. |
Member
|
Would be great to include #128 as well if someone has a chance to review it :) If not, it can wait until next time. |
Member
Author
|
I'll have to disconnect in a few hours for like one week (holidays) so I'm OK for waiting for #128 and release next week with more time to handle it (rolling it to production, monitoring feedbacks,…). |
Member
|
Sounds good to me, enjoy your holiday! |
hugovk
reviewed
Apr 30, 2023
4364c9d to
ebafc1e
Compare
ebafc1e to
8be3006
Compare
Member
Author
|
I'm back! Does this release looks OK to you? |
Member
|
Welcome back, hope you had a relaxing time! The release looks good! |
Member
|
Same here, looks good! A |
Member
Author
|
Released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.