gh-90016: Deprecate default sqlite3 adapters and converters#94276
gh-90016: Deprecate default sqlite3 adapters and converters#94276erlend-aasland merged 9 commits intopython:mainfrom
Conversation
|
cc. @iafisher: would you mind reviewing this? |
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.
Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
left a comment
There was a problem hiding this comment.
Again, +1 to most of Cam's thoughts
|
Reviews addressed in d3dd3b4 |
There was a problem hiding this comment.
LGTM, thanks @erlend-aasland ! Just two minor fixes, both my mistake.
Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst
Outdated
Show resolved
Hide resolved
…409s.rst Co-authored-by: CAM Gerlach <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
|
@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters? @serhiy-storchaka and @malemburg, would you two mind reviewing this? |
Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, see django/django#15815. |
felixxm
left a comment
There was a problem hiding this comment.
@erlend-aasland Thanks 👍
|
I'll resolve the conflicts and land this PR later tonight. |
Closes gh-90016