Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117139: Fix an incorrect borrow in bytecodes.c #122318

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jul 26, 2024

_PyDict_SetItem_Take2 steals both the key (i.e., sub) and the value.

`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 674a50e into python:main Aug 7, 2024
55 of 57 checks passed
@colesbury colesbury deleted the gh-117139-fix-steal branch August 7, 2024 14:45
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants