[smart_holder] Bug fix: `std::unique_ptr` deleter needs to be copied.#4850

Merged

rwgk merged 16 commits intopybind:smart_holderfrom

rwgk:unique_ptr_deleter_sh

Nov 2, 2023

Commits on Sep 22, 2023

Introduce `struct custom_deleter` to ensure the deleter is moved as desired (the lambda function only captures a reference, which can become dangling).
rwgk
committed
Resolve helpful clang-tidy errors.
rwgk
committed
Workaround for gcc 4.8.5, clang 3.6
rwgk
committed

Commits on Nov 1, 2023

Merge branch 'smart_holder' into unique_ptr_deleter_sh
rwgk
committed
Transfer reduced test here.
rwgk
committed
Add missing include (clangd Include Cleaner)
rwgk
committed
Change `std::move` to `std::forward` as suggested by @iwanders.
rwgk
committed
Add missing includes (clangd Include Cleaner)
rwgk
committed
Use new `PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP` to exclude `smart_holder::as_unique_ptr` method from production code.
rwgk
committed
Systematically add `PYBIND11_TESTS_PURE_CPP_SMART_HOLDER_POC_TEST_CPP` to mark code that is not used from production code. Add comment to explain.
rwgk
committed
Very simple experiment related to https://github.com/pybind/pybind11/pull/4850#issuecomment-1789780676
rwgk
committed
Revert "Very simple experiment related to https://github.com/pybind/pybind11/pull/4850#issuecomment-1789780676"
rwgk
committed