Conversation
This comment has been minimized.
This comment has been minimized.
0328c8b to
0506371
Compare
Use correct make target `lint_adoc` for linting documentation with Vale.
Make sure the files resulting from the component template don't produce lint errors without any modifications.
This ensures that all variants of the rendered component-template actually pass the lints which are provided out of the box.
0506371 to
db751c5
Compare
corvus-ch
approved these changes
Jul 6, 2021
ccremer
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
component/<component>.ymlwhen creating a component without post-processing filtersmake linton all variants of the rendered component templateChecklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog