Align move grammar with Pokecrystal #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments explaining the redundant move grammar categories inherited from the Japanese version. This mirrors pokecrystal.
Rangi42
reviewed
Jan 17, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2026
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
used_move_text.asmfromcore.asm, like is done in Pokecrystal. Additionally, update the comments and symbol names ingrammar.asmandused_move_text.asmto align with Pokecrystal.This gives substantially more context on what this redundant code originally did in the Japanese version.