Skip to content

Conversation

@dead-horse
Copy link
Contributor

@dead-horse
Copy link
Contributor Author

ecmaVersion: 7 will throw in acron 4.x

@twada
Copy link
Member

twada commented Feb 13, 2017

@dead-horse Thank you!

Would you use annual version 2017 instead of 8 for ecmaVersion?

Failing tests are due to the changes in embedded recorder. It's not your fault. My bad 😞

@dead-horse dead-horse changed the title fix: ecmaVersion 7 => 8 to support async await fix: ecmaVersion 7 => 2017 to support async await Feb 13, 2017
@dead-horse
Copy link
Contributor Author

@twada fixed, thanks for your quick response and fantastic work!

@twada
Copy link
Member

twada commented Feb 13, 2017

@dead-horse Thanks again. I'll merge this, fix failing tests, then release ASAP.

@twada twada merged commit 2ff5c66 into power-assert-js:master Feb 13, 2017
@dead-horse dead-horse deleted the es8 branch February 13, 2017 08:53
@twada
Copy link
Member

twada commented Feb 13, 2017

Just released as version 2.0.1. Thanks @dead-horse !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants