[PGPRO-14916] Fix compilation after PR #31 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2025 16:13
…alls." This reverts commit bc43f49, which was wrong and broke compilation with versions 17- Tags: vops
…er_path() calls. Caused by 9e9931d2 (postgres) "Re-allow FDWs and custom scan providers to replace joins with pseudoconstant quals." This is a fix from 9dd4c1e (vops), which fixes vops to work with version 17. This fix is improved to take into account that vops should keep working with versions 16-. Also add some cosmetic changes in comments. Tags: vops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #31 was intended to make vops compatible with PostgreSQL 18. Unfortunately, after merging it, vops compile neither with PostgreSQL 18 nor with PostgreSQL 17 and earlier.
Revert erroneous commit, and make vops compatible with PostgreSQL 17, which we already have done, but forgot to merge in master by mistake.
Compatibility with PostgreSQL 18 is NOT provided.