Couple of new methods and minor changes #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funbringer
reviewed
May 3, 2017
| @@ -361,6 +441,9 @@ def cleanup(self): | |||
| pass | |||
|
|
|||
| # remove data directory | |||
| tblspace_list = os.listdir(os.path.join(self.data_dir, 'pg_tblspc')) | |||
There was a problem hiding this comment.
Спорный функционал, я думаю, кто создал - тому и удалять, не нужно это автоматизировать.
| @@ -252,6 +262,26 @@ def init_from_backup(self, root_node, backup_name, has_streaming=False, | |||
| if has_streaming: | |||
| self.enable_streaming(root_node) | |||
|
|
|||
| def set_archiving_conf(self, archive_dir): | |||
There was a problem hiding this comment.
Это - неинвазивная конфигурация, ее должен задавать пользователь (а не фреймворк).
| @@ -277,14 +307,15 @@ def append_conf(self, filename, string): | |||
|
|
|||
| return self | |||
|
|
|||
| def pg_ctl(self, command, params, command_options=[]): | |||
| def pg_ctl(self, command, params={}, command_options=[]): | |||
There was a problem hiding this comment.
Это (pg_ctl) можно закомитить.
There was a problem hiding this comment.
Здесь красивше использовать **kwargs и *args.
| self.working = False | ||
| return None | ||
|
|
||
| def get_pid(self): |
There was a problem hiding this comment.
Если не секрет, зачем это нужно, если есть status()?
| else: | ||
| return None | ||
|
|
||
| def get_control_data(self): |
There was a problem hiding this comment.
Наверное, эта функция пригодится.
There was a problem hiding this comment.
Так вроде она уже была. Хм...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.