OsOps::read methods were corrected (text mode) #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they always read a file as binary. When 'binary' parameter is False we will use 'encoding' parameter to decode bytes into string. Binary read does not allow an usage of 'encoding' parameter (InvalidOperationException is raised). New tests are added.
LocalOps uses "open(filename, mode='r', encoding=encoding)" RemoteOps uses "io.TextIOWrapper(io.BytesIO(binaryData), encoding=encoding)" It solves a problem on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalOperations::read and RemoteOperations::read (text mode) are corrected.
This patch is tested on Windows 11 (Python 3.13) and Ubuntu 24.04 (Python 3.12).
Internal tests for probackup v2 were passed, too.