Skip to content

[PBCKP-360] fix exception check in test_validate_corrupt_page_header_map #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[PBCKP-360] fix exception check in test_validate_corrupt_page_header_map #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 21 additions & 30 deletions tests/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4007,43 +4007,34 @@ def test_validate_corrupt_page_header_map(self):
f.seek(42)
f.write(b"blah")
f.flush()
f.close

try:
with self.assertRaises(ProbackupException) as cm:
self.validate_pb(backup_dir, 'node', backup_id=backup_id)
self.assertEqual(
1, 0,
"Expecting Error because page_header is corrupted.\n "
"Output: {0} \n CMD: {1}".format(
self.output, self.cmd))
except ProbackupException as e:
self.assertRegex(
e.message,
r'WARNING: An error occured during metadata decompression for file "[\w/]+": (data|buffer) error',
'\n Unexpected Error Message: {0}\n CMD: {1}'.format(
repr(e.message), self.cmd))

self.assertIn("Backup {0} is corrupt".format(backup_id), e.message)
e = cm.exception
self.assertRegex(
cm.exception.message,
r'WARNING: An error occured during metadata decompression for file "[\w/]+": (data|buffer) error',
'\n Unexpected Error Message: {0}\n CMD: {1}'.format(
repr(e.message), self.cmd))

try:
self.assertIn("Backup {0} is corrupt".format(backup_id), e.message)

with self.assertRaises(ProbackupException) as cm:
self.validate_pb(backup_dir)
self.assertEqual(
1, 0,
"Expecting Error because page_header is corrupted.\n "
"Output: {0} \n CMD: {1}".format(
self.output, self.cmd))
except ProbackupException as e:
self.assertTrue(
'WARNING: An error occured during metadata decompression' in e.message and
'data error' in e.message,
'\n Unexpected Error Message: {0}\n CMD: {1}'.format(
repr(e.message), self.cmd))

self.assertIn("INFO: Backup {0} data files are valid".format(ok_1), e.message)
self.assertIn("WARNING: Backup {0} data files are corrupted".format(backup_id), e.message)
self.assertIn("INFO: Backup {0} data files are valid".format(ok_2), e.message)
e = cm.exception
self.assertRegex(
e.message,
r'WARNING: An error occured during metadata decompression for file "[\w/]+": (data|buffer) error',
'\n Unexpected Error Message: {0}\n CMD: {1}'.format(
repr(e.message), self.cmd))

self.assertIn("WARNING: Some backups are not valid", e.message)
self.assertIn("INFO: Backup {0} data files are valid".format(ok_1), e.message)
self.assertIn("WARNING: Backup {0} data files are corrupted".format(backup_id), e.message)
self.assertIn("INFO: Backup {0} data files are valid".format(ok_2), e.message)

self.assertIn("WARNING: Some backups are not valid", e.message)

# Clean after yourself
self.del_test_dir(module_name, fname)
Expand Down