Skip to content

[PBCKP-146] truncate cfm files (but calc CRC for whole) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[PBCKP-146] truncate cfm files (but calc CRC for whole) #549

wants to merge 4 commits into from
+429 −120

Conversation

funny-falcon
Copy link
Collaborator

  • store cfm files truncated to non-zero head with coarse granularity (64-4096 bytes)
  • but calculate crc for whole file
  • remember whole file size and use it for crc comparison during validation

@funny-falcon funny-falcon mentioned this pull request Oct 13, 2022
Merged
@funny-falcon
Copy link
Collaborator Author

Alternative to #550

@funny-falcon funny-falcon changed the base branch from master to REL_2_5 October 13, 2022 13:34
@funny-falcon
[PBCKP-146] truncate cfm files (but calc CRC for whole)
7c31f8b 
- store cfm files truncated to non-zero head with coarse granularity
  (64-4096 bytes)
- but calculate crc for whole file
- remember whole file size and use it for crc comparison during validation
@funny-falcon
Copy link
Collaborator Author

Decided to close it.

@Burus Burus added this to the 2.5.9 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmolk gsmolk

@kulaginm kulaginm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@funny-falcon @Burus