Merged
Conversation
tankakatan
approved these changes
Oct 19, 2022
| case ParamMetaType.NOT_FOUND: | ||
| return ( | ||
| <span> | ||
| {param.value} <em>(not found in storage nor blockchain)</em> |
Contributor
There was a problem hiding this comment.
This message looks a bit like an error, as if something was not found and hence may be wrong. I would rather say something like unfamiliar data id. Probably in the future we will emphasise it even more, but for now we need to figure out how common this case actually is.
Contributor
There was a problem hiding this comment.
The less verbose way would be to just say (?)
It can be arbitrary binary data that the contract wants to store, doesn't have to exist in our storage necessarily
Contributor
There was a problem hiding this comment.
Would be nice to have a way to try to decode it into ASCII/UTF-8 if needed, like etherscan does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Point Engine sends any metadata attached to the transaction input that the user is asked to review and approve, these changes will present such metadata in a user-friendly way in the confirmation window.
/_storage/:idthat will open in a new tab.Here are some screenshots (please mind that the
wtfinput in some of the screenshots has been manually added in the code just for testing, to simulate found and not-found blockchain transactions).