fix: simplify useGLTF extension function logic #1903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Hello, I refactored it because there were nested if statements in the extensions function and it seemed like it was not easy to figure out what each setting was for.
What
We've refactored the
setupDracoLoader
andsetupMeshoptDecoder
functions to take advantage of the newDracoLoaderOption
type to simplify the logic and make the extension process simpler.Checklist