Fix Xml_* function handler phpdoc #129
Conversation
2250af8 to
5c5a0fd
Compare
|
You can see the effect of your changes here under "Show diff": https://github.com/phpstan/php-8-stubs/actions/runs/17489848300/job/49676952982?pr=129 Is it what you expect? |
| @@ -820,6 +821,44 @@ private function filterClassPhpDocs(Node\Stmt\ClassLike $class): Node\Stmt\Class | |||
| return $class; | |||
| } | |||
|
|
|||
| private function filterFunctionPhpDocs(Node\Stmt\Function_ $function): Node\Stmt\Function_ | |||
| { | |||
| $namespacedName = $function->namespacedName->toString(); | |||
There was a problem hiding this comment.
Comment with a link to a related discussion why precisely these functions need to be fixed would be appreciated!
There was a problem hiding this comment.
I added the comment inside the if condition if it's ok.
Diff are multiple and this is exactly what I expect ; string|null was already supported before PHP 8.4 (and since the beginning) but the stub was incorrect in php-src. |
|
Thank you! |
Related to https://github.com/php/php-src/pull/12340/files#diff-2c2d210a6a8bc8eae404fa6938be724484865b47cc574d94d24e2c18524c1b40
Needed to solve phpstan/phpstan-src#4254