Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sdk-starter.bat instead of specific file #7

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

macintoshplus
Copy link
Contributor

This action calls the script named sdk-<vs_version>-<arch>.bat to enable the PHP building environment.

This behavior cannot allow executing this action on a new Visual Studio version or processor architecture without adding files into the PHP SDK before.

All sdk-<vs_version>-<arch>.bat scripts call the script sdk-starter.bat with predefined arguments for VS version and architecture.

This PR changes the script called for sdk-starter.bat to allow execution of this action without the need to add new files in PHP SDK.

@cmb69
Copy link
Member

cmb69 commented Nov 17, 2024

Might make sense. @shivammathur, what do you think?

@shivammathur shivammathur merged commit 3c94cc7 into php:master Nov 18, 2024
@macintoshplus macintoshplus deleted the fix_sdk_starter_call branch November 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants