Sync extension enablements symbols #4452
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, when PHP extension is enabled there is usually in most cases also a symbol
HAVE_{EXT_NAME}defined. This patch syncs the help messages a bit for the configuration headers main/php_config.php and main/config.w32.h. Help messages are based on the Autoconf's default messages for similar symbols.Changes
Define to 1 if you have the ext_name extension enabled.Todo/Skipped
Skipped due to not currently having a symbol defined or the symbol is something not related to this PR:
It would be also good to have such step in the function where extension gets enabled and deprecate symbols such as HAVE_LIBGD, HAVE_MYSQLILIB, HAVE_LIBSODIUMLIB etc. probably more something like "prefixed" ones. For example, HAVE_PHP_EXT_{EXT_NAME}:
etc. but I'll leave this be for PHP 8 then I guess.