Remove HAVE_STRTOD and strtod check #4301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to check for the strtod function. It is part of C89 standard which PHP-7.4+ supports. http://port70.net/~nsz/c/c89/c89-draft.html#4.10.1.4
nikic
approved these changes
Jun 23, 2019
Member
nikic
left a comment
There was a problem hiding this comment.
We also ship our own implementation anyway...
Member
Author
|
Applied via cc4134c to PHP-7.4+ P.S: The check was used mostly probably due to oniguruma library in the past and also "fixed" upstream kkos/oniguruma#111 Current extensions also don't use this symbol. Changelog update via #4310 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to check for the strtod function. It is part of C89 standard which PHP-7.4+ supports.
http://port70.net/~nsz/c/c89/c89-draft.html#4.10.1.4