Skip to content

Conversation

@Mdsujansarkar
Copy link
Contributor

Update license

The subject of the verb is "usages," which is plural.
The plural form of the verb "to exist" that agrees with a plural subject is "exist."
"Exists" would be used for a singular subject (e.g., "A legacy usage... exists").

@devnexen
Copy link
Member

devnexen commented Nov 2, 2025

The typo fix looks good to me, however do not know when to update the license's year (part of process ?).

@petk
Copy link
Member

petk commented Nov 2, 2025

When updating license year range, please update also other related parts. See this, as an approximate example 2575e6b

Edit: Actually, it would be best to update license also in PHP-8.3 branch and up. Perhaps a separate PR would be simplest. Case is that this year range has been intentionally a bit delayed due to https://wiki.php.net/rfc/php_license_update but, yes currently range still applies for 2025 and even perhaps for 2026.

@kallesommernielsen
Copy link
Member

@petk @ramsey Can we even update the license text even if its just a typo or grammatical error?

@iluuu1994 iluuu1994 merged commit bda37c1 into php:master Nov 3, 2025
2 checks passed
@iluuu1994
Copy link
Member

Thanks!

@petk
Copy link
Member

petk commented Nov 3, 2025

@petk @ramsey Can we even update the license text even if its just a typo or grammatical error?

This PR otherwise didn't change the typo in the license file but in the coding standards. I believe that changing typos in the license content, should also bump its version if such case would come up. The year range changes are mostly of marketing value so the software looks fresher and it's most clear that the license applies even for the current year. Otherwise, it would be enough to leave only the initial year in it - 1999. It means that this license applies from that year on until something else changed the license of the software or something.

@petk
Copy link
Member

petk commented Nov 3, 2025

@Mdsujansarkar thanks for the fixes. I would simply suggest to wait till 2026-01-01 and bump the year range then to 2026 in PHP-8.3 or PHP-8.4 and up. It's only two months till there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants