Reorganize ext/uri tests - parsing #20340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Oct 30, 2025
TimWolla
reviewed
Oct 31, 2025
TimWolla
reviewed
Nov 1, 2025
ext/uri/tests/whatwg/parsing/path_error_relative_reference_absolute.phpt
Show resolved
Hide resolved
6363dc8 to
4b8554d
Compare
TimWolla
reviewed
Nov 3, 2025
There was a problem hiding this comment.
I'm happy with both the whatwg and rfc3986 directories now. But I would prefer if we kept the “original” numbered tests for now. It's hard for me to verify using the PR view whether or not all cases from the original tests have been properly migrated.
The removal of the obsolete tests should happen in a separate PR. If that part of the change is removed, this LGTM.
4b8554d to
ff94824
Compare
TimWolla
approved these changes
Nov 3, 2025
kocsismate
added a commit
that referenced
this pull request
Nov 3, 2025
* PHP-8.5: Reorganize ext/uri tests - parsing (#20340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.