Allow an exact date/time range for validity when signing a CSR #20330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Oct 30, 2025
| X509_gmtime_adj(X509_getm_notBefore(new_cert), 0); | ||
| X509_gmtime_adj(X509_getm_notAfter(new_cert), 60*60*24*num_days); | ||
| if (num_days == -1) { | ||
| ASN1_TIME_set(X509_getm_notBefore(new_cert), from_time); |
There was a problem hiding this comment.
what about accepting DateTimeInterface?
There was a problem hiding this comment.
Not sure how to do that...
} else if (Z_TYPE_P(tmp) == IS_OBJECT && Z_OBJCE_P(tmp) == php_date_get_date_ce) {
but then what? How would I turn that object into a time_t?
There was a problem hiding this comment.
Maybe like this?
php_date_obj *datetime = php_date_obj_from_obj(Z_OBJ(tmp));
zval timestamp;
zend_call_method_with_0_params(date_obj, php_date_get_date_ce(), NULL, "gettimestamp", ×tamp);
if (Z_TYPE(timestamp) == IS_LONG) {
from = Z_LVAL_P(timestamp);
}
… a CSR This changes the `days` parameter of `openssl_csr_sign()` to a `validity` parameter, which can be either an integer specifying the number of days the certificate is to be valid for (compatible with current usage), or it can be an array of two integer or string values, representing the notBefore and notAfter times to use for the certificate. If they are integers or numeric strings, they are to be a time_t value. If they are non-numeric strings, they are to be an ASN.1 timestamp (YYMMDDHHMMSSZ or YYYYMMDDHHMMSSZ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
daysparameter ofopenssl_csr_sign()to avalidityparameter, which can be either an integer specifying the number of days the certificate is to be valid for (compatible with current usage), or it can be an array of two integer or string values, representing the notBefore and notAfter times to use for the certificate. If they are integers or numeric strings, they are to be a time_t value. If they are non-numeric strings, they are to be an ASN.1 timestamp (YYMMDDHHMMSSZ or YYYYMMDDHHMMSSZ).