uri/standard: Move the parse_url() URI parser into ext/uri/
#19587
+225
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making ext/standard depend on ext/uri/ is a bit iffy (given that it is called *standard*) and having the parser implementation in ext/uri/ makes it easier to find and keep in sync.
…ser_php_parse_url.c
TimWolla
commented
Aug 25, 2025
| return; | ||
| } | ||
|
|
||
| php_raw_url_decode(Z_STRVAL_P(zv), Z_STRLEN_P(zv)); |
There was a problem hiding this comment.
There is a pre-existing bug here. I'll fix it as a follow-up:
Suggested change
| php_raw_url_decode(Z_STRVAL_P(zv), Z_STRLEN_P(zv)); | |
| Z_STRLEN_P(zv) = php_raw_url_decode(Z_STRVAL_P(zv), Z_STRLEN_P(zv)); |
kocsismate
approved these changes
Aug 26, 2025
TimWolla
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. Following #19581 and #19554.